Update dts war version used in testing #1308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TDS 5.4 uses JDK 11 and so cannot be used by netcdf-java and JDK 8 |
|
This way of testing is for historical reasons. Ideally it should be changed to match |
|
Thanks for the comment @DennisHeimbigner! Was just re-investigating why Netcdf-java needs gretty and came across this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I'm not sure why we test opendap this way, but we use gretty and the TDS's dts.war to test the opendap client. This version was badly out of date, so this PR updates it. Tests are passing on Jenkins on this branch: https://jenkins-aws.unidata.ucar.edu/view/Users/job/tara-netcdf-java/49/